Issue 1415183009: Adds check for `AsExpression`s (Fix #145).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1415183009: Adds check for `AsExpression`s (Fix #145). (Closed)

Created:
5 years, 1 month ago by pquitslund

Modified:
5 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/linter.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Adds check for `AsExpression`s (Fix #145). * Adds check for `AsExpression`s. * Improves rule template generator w/ more boilerplate. * Improves integration test runner to fail early when rules cannot be found in the registry. Background: * bug: https://github.com/dart-lang/linter/issues/145 * style guide: https://github.com/flutter/engine/blob/master/sky/specs/style-guide.md R=brianwilkerson@google.com Committed: https://github.com/dart-lang/linter/commit/09f335118e39d233ae08ac60a717df559a73862c

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -8 lines)			Patch
M	lib/src/rules.dart	View		2 chunks	+2 lines, -0 lines	0 comments	Download
A	lib/src/rules/avoid_as.dart	View		1 chunk	+58 lines, -0 lines	0 comments	Download
M	test/rule_test.dart	View	1	2 chunks	+11 lines, -2 lines	0 comments	Download
A +	test/rules/avoid_as.dart	View		1 chunk	+11 lines, -3 lines	0 comments	Download
M	tool/rule.dart	View		2 chunks	+12 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

pquitslund

5 years, 1 month ago (2015-11-06 23:03:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
09f335118e39d233ae08ac60a717df559a73862c (presubmit successful).