Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14150002: Remove StreamSink(replaced by EventSink) and make IOSink extend EventSink. (Closed)

Created:
7 years, 8 months ago by Anders Johnsen
Modified:
7 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove StreamSink(replaced by EventSink) and make IOSink extend EventSink. With this change 'writeBytes' was renamed to 'add'. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21275

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -108 lines) Patch
M pkg/http/test/safe_http_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/lib/src/scheduled_server/safe_http_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/socket_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/chat/chat_server_lib.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/async/stream.dart View 1 3 chunks +2 lines, -14 lines 0 comments Download
M sdk/lib/async/stream_controller.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/http_impl.dart View 4 chunks +12 lines, -5 lines 0 comments Download
M sdk/lib/io/io_sink.dart View 4 chunks +18 lines, -5 lines 0 comments Download
M sdk/lib/io/stdio.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/io/websocket_impl.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/isolate/isolate_stream.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/isolate/global_error_handler_stream_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/dart_std_io_pipe_script.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/echo_server_stream_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/file_output_stream_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/file_system_links_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/file_test.dart View 1 4 chunks +6 lines, -6 lines 0 comments Download
M tests/standalone/io/http_body_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/http_client_connect_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_client_request_test.dart View 4 chunks +7 lines, -7 lines 0 comments Download
M tests/standalone/io/http_close_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_compression_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_head_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/http_keep_alive_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_read_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_server_early_client_close_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_server_response_test.dart View 4 chunks +7 lines, -7 lines 0 comments Download
M tests/standalone/io/http_shutdown_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_broken_pipe_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_std_io_script.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/process_stderr_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_stdout_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/raw_secure_socket_pause_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/raw_secure_socket_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/regress_7191_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/secure_client_server_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/secure_multiple_client_server_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/secure_server_socket_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/secure_socket_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/socket_exception_test.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/standalone/io/socket_invalid_arguments_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/socket_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/io/stdout_bad_argument_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/stdout_stderr_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/stream_pipe_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/safe_http_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/test_pub.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Anders Johnsen
7 years, 8 months ago (2013-04-11 07:05:07 UTC) #1
Søren Gjesse
lgtm, thanks Please send out a "breaking change" mail on dart-misc.
7 years, 8 months ago (2013-04-11 07:26:51 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/14150002/diff/1/sdk/lib/async/stream.dart File sdk/lib/async/stream.dart (right): https://codereview.chromium.org/14150002/diff/1/sdk/lib/async/stream.dart#newcode932 sdk/lib/async/stream.dart:932: close(); keep. The EventSink.close should be assumed not ...
7 years, 8 months ago (2013-04-11 12:45:00 UTC) #3
Anders Johnsen
https://codereview.chromium.org/14150002/diff/1/sdk/lib/async/stream.dart File sdk/lib/async/stream.dart (right): https://codereview.chromium.org/14150002/diff/1/sdk/lib/async/stream.dart#newcode932 sdk/lib/async/stream.dart:932: close(); On 2013/04/11 12:45:01, floitsch wrote: > keep. > ...
7 years, 8 months ago (2013-04-11 12:53:05 UTC) #4
Anders Johnsen
7 years, 8 months ago (2013-04-11 12:55:01 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r21275 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698