Issue 1414793015: Use the async package's CancelableOperation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1414793015: Use the async package's CancelableOperation. (Closed)

Created:
5 years, 1 month ago by nweiz

Modified:
5 years, 1 month ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -514 lines)			Patch
M	lib/src/runner/browser/browser_manager.dart	View	3 chunks	+9 lines, -7 lines	0 comments	Download
M	lib/src/runner/browser/dartium.dart	View	4 chunks	+6 lines, -7 lines	0 comments	Download
M	lib/src/runner/environment.dart	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	lib/src/runner/vm/environment.dart	View	2 chunks	+3 lines, -2 lines	0 comments	Download
D	lib/src/util/cancelable_future.dart	View	1 chunk	+0 lines, -217 lines	0 comments	Download
M	lib/src/utils.dart	View	2 chunks	+20 lines, -21 lines	0 comments	Download
M	pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
D	test/util/cancelable_future_test.dart	View	1 chunk	+0 lines, -255 lines	0 comments	Download

Total messages: 3 (0 generated)

kevmoo

LGTM FYI: scheduled_test will need a constraint bump once this releases – pub get doesn't ...

5 years, 1 month ago (2015-11-05 01:53:03 UTC) #2

nweiz

5 years, 1 month ago (2015-11-05 23:19:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e4f82b38523feaeb9be5e7b6f1dd77bc91624d12 (presubmit successful).