Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1414793007: Lint to check for declared return types (#146). (Closed)

Created:
5 years, 1 month ago by pquitslund
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/linter.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -1 line) Patch
M lib/src/rules.dart View 2 chunks +2 lines, -0 lines 0 comments Download
A lib/src/rules/always_declare_return_types.dart View 1 chunk +84 lines, -0 lines 0 comments Download
M test/_data/p5/p5.dart View 1 chunk +1 line, -1 line 0 comments Download
A test/rules/always_declare_return_types.dart View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
pquitslund
5 years, 1 month ago (2015-11-02 17:58:10 UTC) #2
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-11-02 18:23:41 UTC) #3
pquitslund
5 years, 1 month ago (2015-11-02 18:30:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2689ad32dc8fc7e56968c8bbd0c1d2629d104fc9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698