Issue 14146019: Fixed version.dart to use Future.immediate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14146019: Fixed version.dart to use Future.immediate (Closed)

Created:
7 years, 8 months ago by kustermann

Modified:
7 years, 8 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixed version.dart to use Future.immediate We use a checked-in binary of dart that doesn't have Future.value(). BUG=http://dartbug.com/10193 Committed: https://code.google.com/p/dart/source/detail?r=22010

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/release/version.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kustermann

7 years, 8 months ago (2013-04-25 07:52:30 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22010 (presubmit successful).

Expand Messages | Collapse Messages