Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 141433024: pkg/mime: formatting, finals, consts, etc (Closed)

Created:
6 years, 11 months ago by kevmoo
Modified:
6 years, 10 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/mime: formatting, finals, consts, etc R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=32072

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -32 lines) Patch
M pkg/mime/lib/src/extension_map.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/mime/lib/src/magic_number.dart View 1 1 chunk +18 lines, -18 lines 0 comments Download
M pkg/mime/lib/src/mime_type.dart View 6 chunks +10 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kevmoo
6 years, 11 months ago (2014-01-28 06:12:55 UTC) #1
Anders Johnsen
lgtm, with comments. https://codereview.chromium.org/141433024/diff/1/pkg/mime/lib/src/extension_map.dart File pkg/mime/lib/src/extension_map.dart (right): https://codereview.chromium.org/141433024/diff/1/pkg/mime/lib/src/extension_map.dart#newcode9 pkg/mime/lib/src/extension_map.dart:9: const Map<String, String> _DEFAULT_EXTENSION_MAP = const ...
6 years, 11 months ago (2014-01-28 08:11:54 UTC) #2
kevmoo
https://codereview.chromium.org/141433024/diff/1/pkg/mime/lib/src/extension_map.dart File pkg/mime/lib/src/extension_map.dart (right): https://codereview.chromium.org/141433024/diff/1/pkg/mime/lib/src/extension_map.dart#newcode9 pkg/mime/lib/src/extension_map.dart:9: const Map<String, String> _DEFAULT_EXTENSION_MAP = const <String, String> { ...
6 years, 10 months ago (2014-01-28 17:23:54 UTC) #3
kevmoo
6 years, 10 months ago (2014-01-28 17:24:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r32072 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698