Add support for more typed data types on native ports

Add support for more typed data types on native ports

Renamed the kUint8Array type for a Dart_CObject structure to
kByteArray to support all typed data types. The specific type is
stored in a separate type field. No matter what the specific type is,
the length of the byte array is always in bytes.

R=ager@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=21423

[Søren Gjesse, 2013-04-11 14:00:46]

Added Int8, Int16 and Uint16.

I will add the rest in a separate CL when this one is accepted.

[Mads Ager (google), 2013-04-12 09:03:45]

LGTM

https://codereview.chromium.org/14142008/diff/1/runtime/bin/dartutils.h
File runtime/bin/dartutils.h (right):

https://codereview.chromium.org/14142008/diff/1/runtime/bin/dartutils.h#newco...
runtime/bin/dartutils.h:208: Dart_CObject::ByteArrayType byte_array_type() {
Instead of ByteArray maybe we should use TypedData?

https://codereview.chromium.org/14142008/diff/1/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/14142008/diff/1/runtime/include/dart_api.h#ne...
runtime/include/dart_api.h:946: * All the different types from dart:typeddata
are all expopsed as
are all expopsed -> are exposed

https://codereview.chromium.org/14142008/diff/1/runtime/include/dart_api.h#ne...
runtime/include/dart_api.h:948: * as_byte_array structure. No matter what
specific type the byte
Maybe shorten the last sentence to just: "The length in the byte array structure
is always in bytes."

https://codereview.chromium.org/14142008/diff/1/runtime/vm/dart_api_message.cc
File runtime/vm/dart_api_message.cc (right):

https://codereview.chromium.org/14142008/diff/1/runtime/vm/dart_api_message.c...
runtime/vm/dart_api_message.cc:1027: class_id = kTypedDataUint8ArrayCid;
Shouldn't this be an UNIMPLEMENTED instead. The default to Uint8Array doesn't
really make sense.

[Søren Gjesse, 2013-04-15 09:02:11]

Committed patchset #2 manually as r21423 (presubmit successful).

[Søren Gjesse, 2013-04-15 09:14:34]

https://codereview.chromium.org/14142008/diff/1/runtime/bin/dartutils.h
File runtime/bin/dartutils.h (right):

https://codereview.chromium.org/14142008/diff/1/runtime/bin/dartutils.h#newco...
runtime/bin/dartutils.h:208: Dart_CObject::ByteArrayType byte_array_type() {
On 2013/04/12 09:03:46, Mads Ager wrote:
> Instead of ByteArray maybe we should use TypedData?

You are right. Done.

https://codereview.chromium.org/14142008/diff/1/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/14142008/diff/1/runtime/include/dart_api.h#ne...
runtime/include/dart_api.h:946: * All the different types from dart:typeddata
are all expopsed as
On 2013/04/12 09:03:46, Mads Ager wrote:
> are all expopsed -> are exposed

Done.

https://codereview.chromium.org/14142008/diff/1/runtime/include/dart_api.h#ne...
runtime/include/dart_api.h:948: * as_byte_array structure. No matter what
specific type the byte
On 2013/04/12 09:03:46, Mads Ager wrote:
> Maybe shorten the last sentence to just: "The length in the byte array
structure
> is always in bytes."

Done.

https://codereview.chromium.org/14142008/diff/1/runtime/vm/dart_api_message.cc
File runtime/vm/dart_api_message.cc (right):

https://codereview.chromium.org/14142008/diff/1/runtime/vm/dart_api_message.c...
runtime/vm/dart_api_message.cc:1027: class_id = kTypedDataUint8ArrayCid;
On 2013/04/12 09:03:46, Mads Ager wrote:
> Shouldn't this be an UNIMPLEMENTED instead. The default to Uint8Array doesn't
> really make sense.

Done.

[siva, 2013-04-15 23:28:45]

https://codereview.chromium.org/14142008/diff/6001/runtime/bin/dartutils.h
File runtime/bin/dartutils.h (right):

https://codereview.chromium.org/14142008/diff/6001/runtime/bin/dartutils.h#ne...
runtime/bin/dartutils.h:208: Dart_CObject::TypedDataType byte_array_type() {
for consistency should we name this typed_data_type() as well?

https://codereview.chromium.org/14142008/diff/6001/runtime/bin/dartutils.h#ne...
runtime/bin/dartutils.h:459: uint8_t* Buffer() const { return
cobject_->value.as_typed_data.values; }
probably need accessors:

Peer
Callback

etc. for the external typed data cases.

https://codereview.chromium.org/14142008/diff/6001/runtime/bin/dartutils.h#ne...
runtime/bin/dartutils.h:475: };
Is this class CObjectUint8Array still needed I could not find any references to
it in the code.

https://codereview.chromium.org/14142008/diff/6001/runtime/bin/dartutils.h#ne...
runtime/bin/dartutils.h:494: };
Can the code in file.cc that creates objects of ths class
(CObjectExternalUint8Array) be made to create CobjectTypedData objects. Then we
could get rid of this class too.

https://codereview.chromium.org/14142008/diff/6001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/14142008/diff/6001/runtime/include/dart_api.h...
runtime/include/dart_api.h:969: kUint8Array,
Don't we also need the kUint8ClampedArray type here?

https://codereview.chromium.org/14142008/diff/6001/runtime/vm/dart_api_messag...
File runtime/vm/dart_api_message.cc (right):

https://codereview.chromium.org/14142008/diff/6001/runtime/vm/dart_api_messag...
runtime/vm/dart_api_message.cc:149: intptr_t length_in_bytes = SizeInBytes(type)
* length;
The code for SizeInBytes is duplicated here and in file.cc

Why not use
TypedData::ElementSizeInBytes(kInt8ArrayCid + (type -
Dart_Cobject::kInt8Array));

(Once kUint8ClampedArray is also added to the type list).

https://codereview.chromium.org/14142008/diff/6001/runtime/vm/dart_api_messag...
runtime/vm/dart_api_message.cc:259: }
Ditto comment about GetTypedDataTypeElementSize, maybe we could just use
TypedData::ElementSizeInBytes(cid);