pkg/shelf: Use CaseInsensitiveMap from pkg/http_handler

Use CaseInsensitiveMap from pkg/http_handler

...and UnmodifiableMapView from dart:collection

R=nweiz@google.com

Committed: https://github.com/dart-lang/shelf/commit/8f447837ab8e5b2c67b10bcad47baf51b987faa0

[kevmoo, 2015-10-19 23:35:59]

kevmoo@google.com changed reviewers:
+ nweiz@google.com

[nweiz, 2015-10-20 21:06:50]

https://codereview.chromium.org/1413933003/diff/1/lib/src/shelf_unmodifiable_...
File lib/src/shelf_unmodifiable_map.dart (right):

https://codereview.chromium.org/1413933003/diff/1/lib/src/shelf_unmodifiable_...
lib/src/shelf_unmodifiable_map.dart:12: //              
https://codereview.chromium.org/1319783003/
Will we be able to preserve case-insensitivity with this?

https://codereview.chromium.org/1413933003/diff/1/lib/src/shelf_unmodifiable_...
lib/src/shelf_unmodifiable_map.dart:16: final bool ignoreKeyCase;
Why is this public?

[kevmoo, 2015-10-21 00:17:17]

https://codereview.chromium.org/1413933003/diff/1/lib/src/shelf_unmodifiable_...
File lib/src/shelf_unmodifiable_map.dart (right):

https://codereview.chromium.org/1413933003/diff/1/lib/src/shelf_unmodifiable_...
lib/src/shelf_unmodifiable_map.dart:12: //              
https://codereview.chromium.org/1319783003/
On 2015/10/20 21:06:50, nweiz wrote:
> Will we be able to preserve case-insensitivity with this?

perhaps not

https://codereview.chromium.org/1413933003/diff/1/lib/src/shelf_unmodifiable_...
lib/src/shelf_unmodifiable_map.dart:16: final bool ignoreKeyCase;
On 2015/10/20 21:06:50, nweiz wrote:
> Why is this public?

same reason ShelfUnmodifiableMap is public – but it need not be

[nweiz, 2015-10-21 00:19:21]

lgtm

https://codereview.chromium.org/1413933003/diff/1/lib/src/shelf_unmodifiable_...
File lib/src/shelf_unmodifiable_map.dart (right):

https://codereview.chromium.org/1413933003/diff/1/lib/src/shelf_unmodifiable_...
lib/src/shelf_unmodifiable_map.dart:16: final bool ignoreKeyCase;
On 2015/10/21 00:17:17, kevmoo wrote:
> On 2015/10/20 21:06:50, nweiz wrote:
> > Why is this public?
> 
> same reason ShelfUnmodifiableMap is public – but it need not be

ShelfUnmodifiableMap is public because it needs to be used outside this file,
but I don't think the same is true for ignoreKeyCase.

https://codereview.chromium.org/1413933003/diff/20001/lib/src/shelf_unmodifia...
File lib/src/shelf_unmodifiable_map.dart (right):

https://codereview.chromium.org/1413933003/diff/20001/lib/src/shelf_unmodifia...
lib/src/shelf_unmodifiable_map.dart:29: // source.ignoreKeyCase: the input
cannot be transformed any more
_ignoreKeyCase

[kevmoo, 2015-10-21 00:20:55]

https://codereview.chromium.org/1413933003/diff/20001/lib/src/shelf_unmodifia...
File lib/src/shelf_unmodifiable_map.dart (right):

https://codereview.chromium.org/1413933003/diff/20001/lib/src/shelf_unmodifia...
lib/src/shelf_unmodifiable_map.dart:29: // source.ignoreKeyCase: the input
cannot be transformed any more
On 2015/10/21 00:19:21, nweiz wrote:
> _ignoreKeyCase

Done.

[kevmoo, 2015-10-21 00:21:11]

Committed patchset #3 (id:40001) manually as
8f447837ab8e5b2c67b10bcad47baf51b987faa0 (presubmit successful).