Issue 14139032: Fix broken Mac OS socket code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14139032: Fix broken Mac OS socket code (Closed)

Created:
7 years, 8 months ago by Søren Gjesse

Modified:
7 years, 8 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix broken Mac OS socket code The order of the fields in the sockaddr structures on Mac OS was different and we where relying on the Linux/Windows order of fields. This should now be platform independent. TBR=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=21940

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -24 lines)			Patch
M	runtime/bin/socket.h	View	5 chunks	+5 lines, -6 lines	0 comments	Download
M	runtime/bin/socket_android.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/bin/socket_linux.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/bin/socket_macos.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/bin/socket_win.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

7 years, 8 months ago (2013-04-24 11:52:05 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r21940 (presubmit successful).

Expand Messages | Collapse Messages