Issue 14139011: Print the failure summary by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14139011: Print the failure summary by default (Closed)

Created:
7 years, 8 months ago by kustermann

Modified:
7 years, 8 months ago

Reviewers:
ricow1, ahe, Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Print the failure summary by default It was requested that we should print the failure summary by default (again). This will print all failures twice. Committed: https://code.google.com/p/dart/source/detail?r=21361

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	tools/test.dart	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

LGTM, with comment. Thanks - I don't trust the failure listing in the separate page, ...

7 years, 8 months ago (2013-04-11 17:01:57 UTC) #3

kustermann

Committed patchset #2 manually as r21361 (presubmit successful).

7 years, 8 months ago (2013-04-12 15:08:42 UTC) #4

kustermann

7 years, 8 months ago (2013-04-12 15:08:52 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/14139011/diff/1/tools/test.dart
File tools/test.dart (right):

https://codereview.chromium.org/14139011/diff/1/tools/test.dart#newcode201
tools/test.dart:201: var printFaiureSummary = progressIndicator != 'buildbot';
On 2013/04/11 17:01:57, Bill Hesse wrote:
> I would call this variable printFailureSummary, rather than
printFaiureSummary.

Done.

Expand Messages | Collapse Messages