Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 1413713010: Fix error detection for a non-existent global script. (Closed)

Created:
5 years, 1 month ago by nweiz
Modified:
5 years, 1 month ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix error detection for a non-existent global script. When we tried to run a global script that didn't exist, we would try to load an AssetEnvironment, which would try to compute the transformers for it. Because the script doesn't exist, the computation would conservatively assume that all transformers had to run in case one of them generated it. To find all the scripts, it iterated through the package's dependencies. Since it's notionally the entrypoint, it tried to include its dev dependencies, but this broke because dev dependencies aren't installed for globally-activated packages. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/a1139b80c0230a429a468f9f411556a3fc183bba

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -15 lines) Patch
M lib/src/barback/dependency_computer.dart View 3 chunks +14 lines, -4 lines 0 comments Download
M lib/src/entrypoint.dart View 2 chunks +9 lines, -3 lines 0 comments Download
M lib/src/executable.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/global_packages.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M test/global/run/nonexistent_script_test.dart View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 1 month ago (2015-10-27 23:53:28 UTC) #1
Bob Nystrom
lgtm
5 years, 1 month ago (2015-10-28 16:01:11 UTC) #2
nweiz
5 years, 1 month ago (2015-10-28 21:24:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a1139b80c0230a429a468f9f411556a3fc183bba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698