Issue 14135014: Adding Uri.parse to AuthorizationException

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14135014: Adding Uri.parse to AuthorizationException (Closed)

Created:
7 years, 7 months ago by Adam

Modified:
7 years, 7 months ago

Reviewers:
Bob Nystrom, nweiz

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Adding Uri.parse to AuthorizationException BUG=https://code.google.com/p/dart/issues/detail?id=10050 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=22199

Patch Set 2 : Moving to next line #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	pkg/oauth2/lib/src/client.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

nweiz

https://chromiumcodereview.appspot.com/14135014/diff/1/pkg/oauth2/lib/src/client.dart File pkg/oauth2/lib/src/client.dart (right): https://chromiumcodereview.appspot.com/14135014/diff/1/pkg/oauth2/lib/src/client.dart#newcode112 pkg/oauth2/lib/src/client.dart:112: params['error'], params['error_description'], Uri.parse(params['error_uri'])); Long line.

7 years, 7 months ago (2013-04-29 19:46:16 UTC) #3

Adam

Done On 2013/04/29 19:46:16, nweiz wrote: > https://chromiumcodereview.appspot.com/14135014/diff/1/pkg/oauth2/lib/src/client.dart > File pkg/oauth2/lib/src/client.dart (right): > > https://chromiumcodereview.appspot.com/14135014/diff/1/pkg/oauth2/lib/src/client.dart#newcode112 ...

7 years, 7 months ago (2013-04-30 00:36:44 UTC) #4

nweiz

7 years, 7 months ago (2013-04-30 21:11:05 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r22199 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14135014: Adding Uri.parse to AuthorizationException (Closed)

Description

Patch Set 1 #

Patch Set 2 : Moving to next line #

Messages