Add dartdoc to the generated utils snapshot

Add dartdoc to the generated utils snapshot

R=amouravski@google.com, kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23575

[ricow1, 2013-04-15 06:28:24]

I have not added windows version yet, awaiting info on why the snapshot
functionality is disabled on windows.

[ahe, 2013-04-15 06:33:18]

Perhaps you should elaborate a bit in the CL description about what this does.

https://codereview.chromium.org/14135007/diff/1/sdk/bin/dartdoc
File sdk/bin/dartdoc (right):

https://codereview.chromium.org/14135007/diff/1/sdk/bin/dartdoc#newcode27
sdk/bin/dartdoc:27: exec "$BIN_DIR"/dart --heap_growth_rate=32 $SNAPSHOT $COLORS
 "--package-root=$BIN_DIR/../packages/" "$@"
Extra space after colors.

Shouldn't it say "dartdoc" somewhere?

Long line.

Remove package-root option.

https://codereview.chromium.org/14135007/diff/1/sdk/bin/dartdoc#newcode29
sdk/bin/dartdoc:29: exec "$BIN_DIR"/dart --heap_growth_rate=32
"--package-root=$BIN_DIR/../packages/"
"$BIN_DIR/../lib/_internal/dartdoc/bin/dartdoc.dart" $COLORS "$@"
Long line.

[ricow1, 2013-04-15 07:06:13]

https://codereview.chromium.org/14135007/diff/1/sdk/bin/dartdoc
File sdk/bin/dartdoc (right):

https://codereview.chromium.org/14135007/diff/1/sdk/bin/dartdoc#newcode27
sdk/bin/dartdoc:27: exec "$BIN_DIR"/dart --heap_growth_rate=32 $SNAPSHOT $COLORS
 "--package-root=$BIN_DIR/../packages/" "$@"
On 2013/04/15 06:33:18, ahe wrote:
> Extra space after colors.
> 
> Shouldn't it say "dartdoc" somewhere?
> 
Yes, debug leftover, sorry

> Long line.
Done
> 
> Remove package-root option.
We need library root, Dan is adding that

https://codereview.chromium.org/14135007/diff/1/sdk/bin/dartdoc#newcode29
sdk/bin/dartdoc:29: exec "$BIN_DIR"/dart --heap_growth_rate=32
"--package-root=$BIN_DIR/../packages/"
"$BIN_DIR/../lib/_internal/dartdoc/bin/dartdoc.dart" $COLORS "$@"
On 2013/04/15 06:33:18, ahe wrote:
> Long line.

Done.

https://codereview.chromium.org/14135007/diff/1/sdk/bin/dartdoc#newcode29
sdk/bin/dartdoc:29: exec "$BIN_DIR"/dart --heap_growth_rate=32
"--package-root=$BIN_DIR/../packages/"
"$BIN_DIR/../lib/_internal/dartdoc/bin/dartdoc.dart" $COLORS "$@"
On 2013/04/15 06:33:18, ahe wrote:
> Long line.

Done.

[kustermann, 2013-04-15 07:48:03]

https://codereview.chromium.org/14135007/diff/5001/sdk/bin/dartdoc
File sdk/bin/dartdoc (right):

https://codereview.chromium.org/14135007/diff/5001/sdk/bin/dartdoc#newcode28
sdk/bin/dartdoc:28: "--package-root=$BIN_DIR/../packages/" "$@"
Since we're using a snapshot, the '--package-root' option should not be
necessary.
But if you pass it, then it probably needs to be passed before '$SNAPSHOT'
otherwise it's not interpreted as a VM option, right?

[Andrei Mouravski, 2013-04-16 20:19:09]

https://codereview.chromium.org/14135007/diff/5001/sdk/lib/_internal/dartdoc/...
File sdk/lib/_internal/dartdoc/bin/dartdoc.dart (right):

https://codereview.chromium.org/14135007/diff/5001/sdk/lib/_internal/dartdoc/...
sdk/lib/_internal/dartdoc/bin/dartdoc.dart:252: main() {
main() should go at the top.

Also, add a doc comment saying why you needed to do mainWithOptions.

https://codereview.chromium.org/14135007/diff/5001/utils/compiler/create_snap...
File utils/compiler/create_snapshot.dart (right):

https://codereview.chromium.org/14135007/diff/5001/utils/compiler/create_snap...
utils/compiler/create_snapshot.dart:38: dartdocMain.mainWithOptions(options);
Why not call this as a process?

[ricow1, 2013-04-17 06:58:49]

https://codereview.chromium.org/14135007/diff/5001/sdk/bin/dartdoc
File sdk/bin/dartdoc (right):

https://codereview.chromium.org/14135007/diff/5001/sdk/bin/dartdoc#newcode28
sdk/bin/dartdoc:28: "--package-root=$BIN_DIR/../packages/" "$@"
On 2013/04/15 07:48:03, kustermann wrote:
> Since we're using a snapshot, the '--package-root' option should not be
> necessary.
> But if you pass it, then it probably needs to be passed before '$SNAPSHOT'
> otherwise it's not interpreted as a VM option, right?
As I mentioned on Peters question, we don't need package root, we need library
root instead, Dan is adding support for that. (btw, to make the confusion
complete dartdoc also have a --package-root option!)

https://codereview.chromium.org/14135007/diff/5001/utils/compiler/create_snap...
File utils/compiler/create_snapshot.dart (right):

https://codereview.chromium.org/14135007/diff/5001/utils/compiler/create_snap...
utils/compiler/create_snapshot.dart:38: dartdocMain.mainWithOptions(options);
On 2013/04/16 20:19:09, Andrei Mouravski wrote:
> Why not call this as a process?
I guess I was not clear about this in the cl since this is just adding dartdoc.

We are creating a snapshot using the code we produce here and the code will not
be available!

The reason for this small wrapper is that (just guessing) 95% of the code
between dart2js and dartdoc is shared - so having just one snapshot makes sense.

We want to move code out of sdk/lib/_internal and (for now) just retain the bare
minimum (something like _internal/libraries.dart,
_internal/compiler/implementation/lib and _internal/dartdoc/static)

[Andrei Mouravski, 2013-04-25 03:17:39]

lgtm

Darn. I thought this was already submitted. Sorry!

[Andrei Mouravski, 2013-05-10 15:37:38]

On 2013/04/25 03:17:39, Andrei Mouravski wrote:
> lgtm
> 
> Darn. I thought this was already submitted. Sorry!

Is there a reason this hasn't gone in yet?

[Andrei Mouravski, 2013-05-10 15:38:11]

On 2013/05/10 15:37:38, Andrei Mouravski wrote:
> On 2013/04/25 03:17:39, Andrei Mouravski wrote:
> > lgtm
> > 
> > Darn. I thought this was already submitted. Sorry!
> 
> Is there a reason this hasn't gone in yet?

Err. I mean that in the nicest way possible. I was wondering if there was
something I needed to do to help get this in.

[Andrei Mouravski, 2013-05-28 23:59:16]

Rico, any word on this?

[ricow1, 2013-06-03 11:44:46]

PTAL

https://codereview.chromium.org/14135007/diff/5001/sdk/lib/_internal/dartdoc/...
File sdk/lib/_internal/dartdoc/bin/dartdoc.dart (right):

https://codereview.chromium.org/14135007/diff/5001/sdk/lib/_internal/dartdoc/...
sdk/lib/_internal/dartdoc/bin/dartdoc.dart:252: main() {
On 2013/04/16 20:19:09, Andrei Mouravski wrote:
> main() should go at the top.
> 
> Also, add a doc comment saying why you needed to do mainWithOptions.

Done.

[kustermann, 2013-06-03 11:58:55]

lgtm with comments, but I'm not so familiar with this.

https://codereview.chromium.org/14135007/diff/17001/sdk/bin/dartdoc
File sdk/bin/dartdoc (right):

https://codereview.chromium.org/14135007/diff/17001/sdk/bin/dartdoc#newcode27
sdk/bin/dartdoc:27: echo $BIN_DIR
Do we need the 'echo $BIN_DIR'?

https://codereview.chromium.org/14135007/diff/17001/sdk/lib/_internal/dartdoc...
File sdk/lib/_internal/dartdoc/bin/dartdoc.dart (right):

https://codereview.chromium.org/14135007/diff/17001/sdk/lib/_internal/dartdoc...
sdk/lib/_internal/dartdoc/bin/dartdoc.dart:243: var staticPath =
What is this 'var staticPath =' doing here?

[ricow1, 2013-06-03 12:08:19]

https://codereview.chromium.org/14135007/diff/17001/sdk/bin/dartdoc
File sdk/bin/dartdoc (right):

https://codereview.chromium.org/14135007/diff/17001/sdk/bin/dartdoc#newcode27
sdk/bin/dartdoc:27: echo $BIN_DIR
On 2013/06/03 11:58:56, kustermann wrote:
> Do we need the 'echo $BIN_DIR'?

Done.

https://codereview.chromium.org/14135007/diff/17001/sdk/lib/_internal/dartdoc...
File sdk/lib/_internal/dartdoc/bin/dartdoc.dart (right):

https://codereview.chromium.org/14135007/diff/17001/sdk/lib/_internal/dartdoc...
sdk/lib/_internal/dartdoc/bin/dartdoc.dart:243: var staticPath =
On 2013/06/03 11:58:56, kustermann wrote:
> What is this 'var staticPath =' doing here?

Removed, leftover

[ricow1, 2013-06-04 06:06:35]

Committed patchset #4 manually as r23575 (presubmit successful).