Issue 14135006: Reapply "Incrementally recompute dominators when inlining."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14135006: Reapply "Incrementally recompute dominators when inlining." (Closed)

Created:
7 years, 8 months ago by Kevin Millikin (Google)

Modified:
7 years, 8 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply "Incrementally recompute dominators when inlining." Including a fix for a silly off-by-one bug. GrowableArray::TruncateTo takes the new length, not the new last index. Committed: https://code.google.com/p/dart/source/detail?r=21353

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+165 lines, -118 lines)			Patch
M	runtime/vm/flow_graph.h	View	2 chunks	+2 lines, -7 lines	0 comments	Download
M	runtime/vm/flow_graph.cc	View	3 chunks	+1 line, -12 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View	4 chunks	+13 lines, -9 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	3 chunks	+146 lines, -87 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

7 years, 8 months ago (2013-04-12 11:41:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21353 (presubmit successful).

Expand Messages | Collapse Messages