Issue 14135005: Fix 'collection' tests and co19 dartc/dart2js status files.

Issue 14135005: Fix 'collection' tests and co19 dartc/dart2js status files. (Closed)

Created:
7 years, 8 months ago by Anders Johnsen

Modified:
7 years, 8 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix 'collection' tests and co19 dartc/dart2js status files. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21343

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -40 lines)			Patch
M	tests/co19/co19-compiler.status	View		2 chunks	+10 lines, -4 lines	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1	2 chunks	+17 lines, -20 lines	0 comments	Download
M	tests/corelib/collection_from_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/corelib/collection_length_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/corelib/collection_test.dart	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	tests/corelib/collection_to_string_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/html/element_classes_test.dart	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/14135005/diff/1/tests/co19/co19-dart2dart.status File tests/co19/co19-dart2dart.status (right): https://codereview.chromium.org/14135005/diff/1/tests/co19/co19-dart2dart.status#newcode545 tests/co19/co19-dart2dart.status:545: LibTest/core/List/List.fixedLength_A01_t01: fail # Issue 400 capital "F" (in ...

7 years, 8 months ago (2013-04-12 10:22:13 UTC) #2

Anders Johnsen

https://codereview.chromium.org/14135005/diff/1/tests/co19/co19-dart2dart.status File tests/co19/co19-dart2dart.status (right): https://codereview.chromium.org/14135005/diff/1/tests/co19/co19-dart2dart.status#newcode545 tests/co19/co19-dart2dart.status:545: LibTest/core/List/List.fixedLength_A01_t01: fail # Issue 400 On 2013/04/12 10:22:13, floitsch ...

7 years, 8 months ago (2013-04-12 10:27:31 UTC) #3

Anders Johnsen

7 years, 8 months ago (2013-04-12 10:28:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21343 (presubmit successful).

Expand Messages | Collapse Messages