Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 14130010: Revert "Remove typeddata transferable constructors" (Closed)

Created:
7 years, 8 months ago by vsm
Modified:
7 years, 8 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Remove typeddata transferable constructors" This reverts commit r21576. Looks like I missed some tests. TBR=siva Committed: https://code.google.com/p/dart/source/detail?r=21580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -2 lines) Patch
M runtime/lib/typeddata.dart View 24 chunks +101 lines, -0 lines 0 comments Download
M tests/lib/typeddata/float32x4_list_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/standalone/byte_array_view_optimized_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/typed_data_test.dart View 7 chunks +40 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
vsm
7 years, 8 months ago (2013-04-16 21:22:12 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r21580 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698