Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 141273003: Make constructor names hyphenated in qualifiedName json output. (Closed)

Created:
6 years, 11 months ago by Emily Fortuna
Modified:
6 years, 11 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make constructor names hyphenated in qualifiedName json output. BUG= R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=31902

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M pkg/docgen/lib/docgen.dart View 3 chunks +7 lines, -8 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Emily Fortuna
6 years, 11 months ago (2014-01-16 22:27:10 UTC) #1
Alan Knight
https://codereview.chromium.org/141273003/diff/1/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/141273003/diff/1/pkg/docgen/lib/docgen.dart#newcode1776 pkg/docgen/lib/docgen.dart:1776: String get fileName => packagePrefix + docName; This doesn't ...
6 years, 11 months ago (2014-01-16 22:50:23 UTC) #2
Alan Knight
lgtm
6 years, 11 months ago (2014-01-16 22:51:08 UTC) #3
Emily Fortuna
6 years, 11 months ago (2014-01-16 23:04:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r31902 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698