Issue 1412293005: Defer to engine for option-aware context config.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1412293005: Defer to engine for option-aware context config. (Closed)

Created:
5 years, 1 month ago by pquitslund

Modified:
5 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/analyzer_cli.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Defer to engine for option-aware context config. * Leans on new `configureContext` function to pick up latest options support from engine. * Adds options integration tests. * Cleans up `Driver` test output. BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/analyzer_cli/commit/c93a3d2d1c7715a6c7a067ebdbc9ba716b865226

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+120 lines, -30 lines)			Patch
M	lib/src/driver.dart	View	3 chunks	+8 lines, -2 lines	0 comments	Download
M	lib/src/options.dart	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
A	test/data/empty_options.yaml	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	test/data/no_lints_project/.analysis_options	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	test/data/no_lints_project/test_file.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
A	test/data/options_tests_project/.analysis_options	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A +	test/data/options_tests_project/test_file.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/driver_test.dart	View	9 chunks	+100 lines, -23 lines	0 comments	Download
M	test/strong_mode_test.dart	View	3 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

pquitslund

5 years, 1 month ago (2015-10-29 22:01:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c93a3d2d1c7715a6c7a067ebdbc9ba716b865226 (presubmit successful).