Add special rules in the inferrer that some int operations return an int.

Add special rules in the inferrer that some int operations return an int.

Committed: https://code.google.com/p/dart/source/detail?r=21810

[ngeoffray, 2013-04-22 11:58:24]

I verified that this fixes:
https://code.google.com/p/dart/issues/detail?id=9507.

[kasperl, 2013-04-22 12:11:24]

https://codereview.chromium.org/14120008/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/14120008/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:908:
if (!selector.isCall() && !selector.isOperator()) return null;
How does this deal with abs and remainder? They aren't operators right?
Shouldn't you just remove the isOperator part of the condition?

https://codereview.chromium.org/14120008/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:909:
if (!arguments.named.isEmpty) return null;
Maybe this would be cleaner if you split it out on the selector name with a
switch?

Something like:

switch (selector.name) {
  case const SourceString('*'):
  case const SourceString('+'):
  case const SourceString('%'):
  case const SourceString('remainder'):
    return hasOneArgumentWithType(arguments, intType) ? intType : null;

  case const SourceString('-'):
    if (hasNoArguments(arguments)) return intType;
    if (hasOneArgumentWithType(arguments, intType)) return intType;
    return null;

  case const SourceString('abs'):
    return hasNoArguments(arguments) ? intType : null;
}

[ngeoffray, 2013-04-22 12:31:49]

Thanks Kasper. PTAL, I have incorporated your suggestion, and added a test for
wrong calls to abs and remainder.

https://codereview.chromium.org/14120008/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/14120008/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:909:
if (!arguments.named.isEmpty) return null;
On 2013/04/22 12:11:24, kasperl wrote:
> Maybe this would be cleaner if you split it out on the selector name with a
> switch?
> 
> Something like:
> 
> switch (selector.name) {
>   case const SourceString('*'):
>   case const SourceString('+'):
>   case const SourceString('%'):
>   case const SourceString('remainder'):
>     return hasOneArgumentWithType(arguments, intType) ? intType : null;
> 
>   case const SourceString('-'):
>     if (hasNoArguments(arguments)) return intType;
>     if (hasOneArgumentWithType(arguments, intType)) return intType;
>     return null;
> 
>   case const SourceString('abs'):
>     return hasNoArguments(arguments) ? intType : null;
> }

I like the suggestion. Done.

[kasperl, 2013-04-22 12:36:00]

LGTM!

[ngeoffray, 2013-04-22 12:40:41]

Committed patchset #2 manually as r21810 (presubmit successful).