Issue 14119004: Remove typeddata transferable constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14119004: Remove typeddata transferable constructors (Closed)

Created:
7 years, 8 months ago by vsm

Modified:
7 years, 8 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Revert "Remove typeddata transferable constructors"" Take #2. The only change here is the additional test fix under runtime that I missed. Committed: https://code.google.com/p/dart/source/detail?r=21586

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -204 lines)			Patch
M	runtime/lib/typeddata.dart	View	24 chunks	+0 lines, -101 lines	0 comments	Download
M	runtime/tests/vm/dart/byte_array_test.dart	View	20 chunks	+0 lines, -58 lines	0 comments	Download
M	tests/lib/typeddata/float32x4_list_test.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	tests/standalone/byte_array_view_optimized_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/typed_data_test.dart	View	7 chunks	+1 line, -40 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vsm

7 years, 8 months ago (2013-04-16 22:36:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21586 (presubmit successful).

Expand Messages | Collapse Messages