Issue 14118011: - Implement reflectClass.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14118011: - Implement reflectClass. (Closed)

Created:
7 years, 8 months ago by Ivan Posva

Modified:
7 years, 8 months ago

Reviewers:
bakster, ahe, gbracha

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Implement reflectClass. Committed: https://code.google.com/p/dart/source/detail?r=21610

Patch Set 1 #

Total comments: 3

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -2 lines)			Patch
M	runtime/lib/mirrors.cc	View	2 chunks	+38 lines, -0 lines	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	runtime/lib/mirrors_patch.dart	View	1 chunk	+10 lines, -0 lines	1 comment	Download
M	runtime/vm/bootstrap_natives.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/mirrors/mirrors.dart	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	tests/lib/mirrors/mirrors_test.dart	View	2 chunks	+12 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

Committed patchset #1 manually as r21610 (presubmit successful).

7 years, 8 months ago (2013-04-17 10:11:29 UTC) #2

ahe

7 years, 8 months ago (2013-04-17 10:40:16 UTC) #3

Message was sent while issue was closed.

LGTM

https://codereview.chromium.org/14118011/diff/1/runtime/lib/mirrors_patch.dart
File runtime/lib/mirrors_patch.dart (right):

https://codereview.chromium.org/14118011/diff/1/runtime/lib/mirrors_patch.dar...
runtime/lib/mirrors_patch.dart:40: patch ClassMirror reflectClass(Type key) {
I'd call the argument "type".

https://codereview.chromium.org/14118011/diff/1/tests/lib/mirrors/mirrors_tes...
File tests/lib/mirrors/mirrors_test.dart (right):

https://codereview.chromium.org/14118011/diff/1/tests/lib/mirrors/mirrors_tes...
tests/lib/mirrors/mirrors_test.dart:118: var objectMirror =
classMirror.newInstance(symbolMirror.reflectee,[1234]);
I'm not sure why you created a symbol mirror here, but I guess it can't hurt.

https://codereview.chromium.org/14118011/diff/1/tests/lib/mirrors/mirrors_tes...
tests/lib/mirrors/mirrors_test.dart:118: var objectMirror =
classMirror.newInstance(symbolMirror.reflectee,[1234]);
Missing space after ,

Expand Messages | Collapse Messages