Issue 141163009: Revert r31601 (Use constants from the frame at OSR entry...).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141163009: Revert r31601 (Use constants from the frame at OSR entry...). (Closed)

Created:
6 years, 11 months ago by Florian Schneider

Modified:
6 years, 11 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Anders Johnsen

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Revert r31601 (Use constants from the frame at OSR entry...). Because this CL also changed the way spill slots are allocated for catch entry blocks it caused invalid code for optimized try-catch under certain conditions. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=31948

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -72 lines)			Patch
M	runtime/vm/flow_graph.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph.cc	View	6 chunks	+12 lines, -52 lines	0 comments	Download
M	runtime/vm/flow_graph_allocator.cc	View	2 chunks	+13 lines, -13 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/visitor.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

@Srdjan: I'm reverting this for now, since the fix seems to be non-trivial. @Anders: For ...

6 years, 11 months ago (2014-01-17 16:23:47 UTC) #1

Florian Schneider

6 years, 11 months ago (2014-01-20 10:43:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r31948 (presubmit successful).

Expand Messages | Collapse Messages