Issue 14113032: Add helper for parsing stack traces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14113032: Add helper for parsing stack traces. (Closed)

Created:
7 years, 8 months ago by podivilov

Modified:
7 years, 4 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add helper for parsing stack traces. R=antonm@google.com Committed: https://code.google.com/p/dart/source/detail?r=22107

Patch Set 1 #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	tools/dom/src/native_DOMImplementation.dart	View		1 chunk	+9 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm https://codereview.chromium.org/14113032/diff/1/tools/dom/src/native_DOMImplementation.dart File tools/dom/src/native_DOMImplementation.dart (right): https://codereview.chromium.org/14113032/diff/1/tools/dom/src/native_DOMImplementation.dart#newcode46 tools/dom/src/native_DOMImplementation.dart:46: static List parseStackTrace(StackTrace stackTrace) { regexp woodoo looks ...

7 years, 7 months ago (2013-04-29 07:55:53 UTC) #2

podivilov

https://codereview.chromium.org/14113032/diff/1/tools/dom/src/native_DOMImplementation.dart File tools/dom/src/native_DOMImplementation.dart (right): https://codereview.chromium.org/14113032/diff/1/tools/dom/src/native_DOMImplementation.dart#newcode46 tools/dom/src/native_DOMImplementation.dart:46: static List parseStackTrace(StackTrace stackTrace) { On 2013/04/29 07:55:53, Anton ...

7 years, 7 months ago (2013-04-29 08:29:09 UTC) #3

podivilov

7 years, 7 months ago (2013-04-29 08:34:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r22107 (presubmit successful).

Expand Messages | Collapse Messages