Fix HttpBodyHandler to handle missing mimeType.

Fix HttpBodyHandler to handle missing mimeType.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=21432

[Søren Gjesse, 2013-04-15 11:11:28]

lgtm

lgtm

https://codereview.chromium.org/14113006/diff/1/sdk/lib/io/http_body_impl.dart
File sdk/lib/io/http_body_impl.dart (right):

https://codereview.chromium.org/14113006/diff/1/sdk/lib/io/http_body_impl.dar...
sdk/lib/io/http_body_impl.dart:54: String mimeType =
"${contentType.primaryType}/${contentType.subType}";
Maybe add gettet type or value to class ContentType for returning this.

https://codereview.chromium.org/14113006/diff/1/tests/standalone/io/http_body...
File tests/standalone/io/http_body_test.dart (right):

https://codereview.chromium.org/14113006/diff/1/tests/standalone/io/http_body...
tests/standalone/io/http_body_test.dart:101: Expect.equals(body.mimeType,
"text/plain");
Should we add body.contentType to return the full content type?

[Anders Johnsen, 2013-04-15 11:19:26]

PTAL

https://codereview.chromium.org/14113006/diff/1/sdk/lib/io/http_body_impl.dart
File sdk/lib/io/http_body_impl.dart (right):

https://codereview.chromium.org/14113006/diff/1/sdk/lib/io/http_body_impl.dar...
sdk/lib/io/http_body_impl.dart:54: String mimeType =
"${contentType.primaryType}/${contentType.subType}";
On 2013/04/15 11:11:28, Søren Gjesse wrote:
> Maybe add gettet type or value to class ContentType for returning this.

Done.

https://codereview.chromium.org/14113006/diff/1/tests/standalone/io/http_body...
File tests/standalone/io/http_body_test.dart (right):

https://codereview.chromium.org/14113006/diff/1/tests/standalone/io/http_body...
tests/standalone/io/http_body_test.dart:101: Expect.equals(body.mimeType,
"text/plain");
On 2013/04/15 11:11:28, Søren Gjesse wrote:
> Should we add body.contentType to return the full content type?

Well, the charset is not interesting anymore (it's already decoded). But, if the
user really wants it, we still expose the .headers.contentType on the specified
HttpBody's. WDYT?

[Søren Gjesse, 2013-04-15 11:21:21]

lgtm

https://codereview.chromium.org/14113006/diff/5001/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/14113006/diff/5001/sdk/lib/io/http.dart#newco...
sdk/lib/io/http.dart:512: * Gets the mime-type, without the charset.
without the charset -> without any parameters

[Anders Johnsen, 2013-04-15 11:24:19]

Landing.

https://codereview.chromium.org/14113006/diff/5001/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/14113006/diff/5001/sdk/lib/io/http.dart#newco...
sdk/lib/io/http.dart:512: * Gets the mime-type, without the charset.
On 2013/04/15 11:21:21, Søren Gjesse wrote:
> without the charset -> without any parameters

Ahh, ty.

[Anders Johnsen, 2013-04-15 11:24:44]

Committed patchset #3 manually as r21432 (presubmit successful).