Issue 141113006: Fixing TouchEvent.supported

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141113006: Fixing TouchEvent.supported (Closed)

Created:
6 years, 11 months ago by blois

Modified:
6 years, 11 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing TouchEvent.supported It was reporting as not being supported because there's no Window.ontouch, but the constructor is now working. TBR BUG= Committed: https://code.google.com/p/dart/source/detail?r=31907

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -26 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	tests/html/html.status	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_TouchEvent.darttemplate	View	1 chunk	+1 line, -13 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

blois

Committed patchset #1 manually as r31907 (presubmit successful).

6 years, 11 months ago (2014-01-17 02:49:50 UTC) #2

Emily Fortuna

lgtm, but is this just a matter of making sure all the bots are updated ...

6 years, 11 months ago (2014-01-17 18:39:17 UTC) #3

blois

On 2014/01/17 18:39:17, Emily Fortuna wrote: > lgtm, but is this just a matter of ...

6 years, 11 months ago (2014-01-17 18:48:55 UTC) #4

Emily Fortuna

6 years, 11 months ago (2014-01-17 19:16:49 UTC) #5

Message was sent while issue was closed.

So apparently the machines running chrome are already running 32.... so we
shouldn't have seen this failure at all... (?)

Expand Messages | Collapse Messages