Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 14111002: Pass flag --error_on_malformed_type when running gen_snapshot. (Closed)

Created:
7 years, 8 months ago by regis
Modified:
7 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Pass flag --error_on_malformed_type when running gen_snapshot. This will prevent silent mapping of malformed types to 'dynamic' in the core library. Committed: https://code.google.com/p/dart/source/detail?r=21236

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/tools/create_snapshot_bin.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
7 years, 8 months ago (2013-04-10 22:54:35 UTC) #1
Ivan Posva
LGTM -ip
7 years, 8 months ago (2013-04-10 23:01:51 UTC) #2
regis
7 years, 8 months ago (2013-04-10 23:02:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21236 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698