Add the new dart analyzer to the SDK.

Add the new dart analyzer to the SDK.

Committed: https://code.google.com/p/dart/source/detail?r=21479

[devoncarew, 2013-04-13 23:34:01]

This depends on adding a SDK -> analyzer dependency in dart.gyp.

[dgrove, 2013-04-14 09:34:04]

LGTM once my comments have been responded to.

Thanks for all the cleanup in dartanalyzer.bat!

https://codereview.chromium.org/14110004/diff/1/sdk/bin/dartanalyzer.bat
File sdk/bin/dartanalyzer.bat (right):

https://codereview.chromium.org/14110004/diff/1/sdk/bin/dartanalyzer.bat#newc...
sdk/bin/dartanalyzer.bat:42: set
DART_ANALYZER_LIBS=%DART_SDK_HOME%\util\dartanalyzer
I'm not a Windows expert, but does this work  correctly with DART_SDK_HOME has a
space in it?

https://codereview.chromium.org/14110004/diff/1/sdk/bin/dartanalyzer.bat#newc...
sdk/bin/dartanalyzer.bat:44: set
DART_ANALYZER_LIBS=%DART_ANALYZER_HOME%\util\dartanalyzer
ditto

[devoncarew, 2013-04-14 10:44:32]

>
https://codereview.chromium.org/14110004/diff/1/sdk/bin/dartanalyzer.bat#newc...
> sdk/bin/dartanalyzer.bat:42: set
> DART_ANALYZER_LIBS=%DART_SDK_HOME%\util\dartanalyzer
> I'm not a Windows expert, but does this work  correctly with DART_SDK_HOME has
a
> space in it?

So, these two scripts were copied from compiler/scripts/dart_analyzer.bat and
compiler/scripts/dart_analyzer.sh - the dartc sdk scripts. I tried to make as
few modifications to them as necessary in order to get them to work w/ the new
analyzer (though I did remove most of the older rem comments in the bat file).

I'm hoping that the scripts work as well w/ spaces as the dartc ones did. I'll
fire up my windows machine up and make sure that the bat file works properly on
it, with and without spaces. Thanks for the review!

[devoncarew, 2013-04-15 17:05:56]

Committed patchset #1 manually as r21479 (presubmit successful).