Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 1410683011: Make Chain.parse and Trace.parse more similar. (Closed)

Created:
5 years, 1 month ago by nweiz
Modified:
5 years, 1 month ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/stack_trace@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -9 lines) Patch
M CHANGELOG.md View 1 chunk +9 lines, -0 lines 0 comments Download
M lib/src/chain.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M lib/src/trace.dart View 2 chunks +3 lines, -1 line 0 comments Download
M lib/src/utils.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 1 month ago (2015-11-03 00:06:20 UTC) #1
Bob Nystrom
lgtm
5 years, 1 month ago (2015-11-03 20:30:24 UTC) #2
nweiz
5 years, 1 month ago (2015-11-03 21:42:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
609425c56f6747191469b0d5c916c26bda1653af (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698