Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 14106013: Further improve type optimization reusing the type argument vector of the (Closed)

Created:
7 years, 7 months ago by regis
Modified:
7 years, 7 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, Ivan Posva, polux
Visibility:
Public.

Description

Further improve type optimization reusing the type argument vector of the instantiator of generic objects (fixes issue 10149). This optimization considers the generic type argument vector of the instance being allocated as well as the generic type argument vector of the compile time type of the instantiator. If the instance vector is a prefix of the instantiator vector, the instantiator vector can be shared by the new instance. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=22155

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -29 lines) Patch
M runtime/vm/flow_graph_builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 8 chunks +23 lines, -11 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language.h View 9 chunks +14 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M runtime/vm/object.h View 3 chunks +13 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 3 chunks +65 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
7 years, 7 months ago (2013-04-29 22:32:42 UTC) #1
srdjan
lgtm
7 years, 7 months ago (2013-04-29 23:38:55 UTC) #2
regis
7 years, 7 months ago (2013-04-29 23:39:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22155 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698