Issue 14103023: Change our encoding for javac compiles to explicitly use UTF-8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14103023: Change our encoding for javac compiles to explicitly use UTF-8. (Closed)

Created:
7 years, 8 months ago by devoncarew

Modified:
7 years, 8 months ago

Reviewers:
ahe, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Change our encoding for javac compiles to explicitly use UTF-8. Committed: https://code.google.com/p/dart/source/detail?r=21684

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -14 lines)			Patch
M	compiler/build.xml	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download
M	editor/tools/compile_analyzer.py	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java	View	1 2	6 chunks	+7 lines, -7 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticTypeWarningCode.java	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/type/InterfaceTypeImplTest.java	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

devoncarew

There didn't seem to be any strong opinions, so I choose UTF-8. I also zapped ...

7 years, 8 months ago (2013-04-17 18:33:19 UTC) #1

Brian Wilkerson

LGTM. Guess I need to be more careful when copying from the specification.

7 years, 8 months ago (2013-04-17 18:48:38 UTC) #2

devoncarew

7 years, 8 months ago (2013-04-18 17:47:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r21684 (presubmit successful).