Issue 14103010: Change hasSubscribers to hasListener.

Issue 14103010: Change hasSubscribers to hasListener. (Closed)

Created:
7 years, 8 months ago by floitsch

Modified:
7 years, 8 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change hasSubscribers to hasListener. Committed: https://code.google.com/p/dart/source/detail?r=21337

Patch Set 2 : Addressed comments. #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -57 lines)			Patch
M	pkg/scheduled_test/lib/src/mock_clock.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/socket_patch.dart	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/async/stream.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/async/stream_controller.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/async/stream_impl.dart	View	1	18 chunks	+20 lines, -20 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/indexed_db/dartium/indexed_db_dartium.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/io/file_impl.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/io/http_parser.dart	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/io/io_sink.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/io/secure_server_socket.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/io/secure_socket.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/web_audio/dart2js/web_audio_dart2js.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/web_audio/dartium/web_audio_dartium.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/async/stream_state_helper.dart	View	1	4 chunks	+8 lines, -8 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Geolocation.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_IDBObjectStore.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_ScriptProcessorNode.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/error_group.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM https://codereview.chromium.org/14103010/diff/1/sdk/lib/async/stream_impl.dart File sdk/lib/async/stream_impl.dart (right): https://codereview.chromium.org/14103010/diff/1/sdk/lib/async/stream_impl.dart#newcode440 sdk/lib/async/stream_impl.dart:440: hadSubscribers = hasListener; hadListener https://codereview.chromium.org/14103010/diff/1/sdk/lib/async/stream_impl.dart#newcode761 sdk/lib/async/stream_impl.dart:761: bool hadSubscribers ...

7 years, 8 months ago (2013-04-11 18:10:13 UTC) #2

floitsch

https://codereview.chromium.org/14103010/diff/1/sdk/lib/async/stream_impl.dart File sdk/lib/async/stream_impl.dart (right): https://codereview.chromium.org/14103010/diff/1/sdk/lib/async/stream_impl.dart#newcode440 sdk/lib/async/stream_impl.dart:440: hadSubscribers = hasListener; On 2013/04/11 18:10:13, Anders Johnsen wrote: ...

7 years, 8 months ago (2013-04-12 09:29:22 UTC) #3

floitsch

7 years, 8 months ago (2013-04-12 09:30:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21337 (presubmit successful).

Expand Messages | Collapse Messages