Remove use of Expect from test scripts and idlparser_test.

Remove use of Expect from test scripts and idlparser_test.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=21287

[kustermann, 2013-04-11 11:51:14]

lgtm in general.

But I'd feel much more comfortable if we would enable these checks by default
(not only in checked mode).

The testing scripts were (and IMHO still are) somewhat fragile. Having these
checks in shouldn't hurt performance but makes the scripts more robust (If we
change anything in the scripts, we can at least be sure that the assumptions we
had earlier are not violated.). [We could just add an Expect class to
'dart/tools/testing/utils.dart' and use that.]

https://codereview.chromium.org/14103003/diff/1/tools/testing/dart/test_suite...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/14103003/diff/1/tools/testing/dart/test_suite...
tools/testing/dart/test_suite.dart:1016: assert(runtime == "drt");
I'd throw here if runtime is not 'drt'.

[Bill Hesse, 2013-04-11 12:46:48]

PTAL.  I added --checked to test.py.

https://codereview.chromium.org/14103003/diff/1/tools/testing/dart/test_suite...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/14103003/diff/1/tools/testing/dart/test_suite...
tools/testing/dart/test_suite.dart:1016: assert(runtime == "drt");
On 2013/04/11 11:51:14, kustermann wrote:
> I'd throw here if runtime is not 'drt'.

Done.

[kustermann, 2013-04-11 15:02:59]

lgtm

[Bill Hesse, 2013-04-11 15:54:05]

Committed patchset #3 manually as r21287 (presubmit successful).

[Ivan Posva, 2013-04-11 16:37:47]

DBC
-Ivan

https://codereview.chromium.org/14103003/diff/6005/tools/test.py
File tools/test.py (right):

https://codereview.chromium.org/14103003/diff/6005/tools/test.py#newcode22
tools/test.py:22: command = [utils.DartBinary(), '--checked', dart_test_script]
+ args
Do you really want to run the test script in checked mode ALL of the time? What
is the performance impact on cycle times?

[kustermann, 2013-04-11 16:41:38]

> Do you really want to run the test script in checked mode ALL of the time?
What
> is the performance impact on cycle times?

We'll see that soon. If it is significant I'll revert the change.

The thing that is important to me is that we still run these checks (whether we
use Expect or assert).