Emit the type test support code to the right output unit.

Emit the type test support code to the right output unit.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32239

[floitsch, 2014-01-17 12:28:06]

LGTM.

https://codereview.chromium.org/141023007/diff/120001/sdk/lib/_internal/compi...
File sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart
(right):

https://codereview.chromium.org/141023007/diff/120001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart:285:
for (ClassElement cls in typeChecks) {
Add TODO that we shouldn't need to run through all classes? Or at least
investigate if it's ok?

https://codereview.chromium.org/141023007/diff/120001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart:314:
checkedGenericFunctionTypes.forEach((_, Set<FunctionType> functionTypes) {
This has the same difficulties as constants (as discussed with Karl).
Add tests (also failing ones), so that we can fix it.

https://codereview.chromium.org/141023007/diff/120001/tests/compiler/dart2js/...
File tests/compiler/dart2js/deferred_emit_type_checks_test.dart (right):

https://codereview.chromium.org/141023007/diff/120001/tests/compiler/dart2js/...
tests/compiler/dart2js/deferred_emit_type_checks_test.dart:40: return
outputs.putIfAbsent("$name.$extension", () => new MemoryOutputSink());
long line.

[sigurdm, 2014-02-03 09:37:31]

https://codereview.chromium.org/141023007/diff/120001/sdk/lib/_internal/compi...
File sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart
(right):

https://codereview.chromium.org/141023007/diff/120001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart:285:
for (ClassElement cls in typeChecks) {
On 2014/01/17 12:28:06, floitsch wrote:
> Add TODO that we shouldn't need to run through all classes? Or at least
> investigate if it's ok?

Done.

https://codereview.chromium.org/141023007/diff/120001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart:314:
checkedGenericFunctionTypes.forEach((_, Set<FunctionType> functionTypes) {
On 2014/01/17 12:28:06, floitsch wrote:
> This has the same difficulties as constants (as discussed with Karl).
> Add tests (also failing ones), so that we can fix it.
I tried creating a failing test but was not able to trigger use of these
signatures. I think these lines can be removed completely.
In this CL I will just add a TODO.

https://codereview.chromium.org/141023007/diff/120001/tests/compiler/dart2js/...
File tests/compiler/dart2js/deferred_emit_type_checks_test.dart (right):

https://codereview.chromium.org/141023007/diff/120001/tests/compiler/dart2js/...
tests/compiler/dart2js/deferred_emit_type_checks_test.dart:40: return
outputs.putIfAbsent("$name.$extension", () => new MemoryOutputSink());
On 2014/01/17 12:28:06, floitsch wrote:
> long line.

Done.

[sigurdm, 2014-02-03 09:55:17]

Committed patchset #2 manually as r32239 (presubmit successful).