Chromium Code Reviews

Issue 140973006: Update [getErrorMessage] to avoid throwing away useful information. (Closed)

Created:
6 years, 11 months ago by nweiz
Modified:
6 years, 11 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update [getErrorMessage] to avoid throwing away useful information. Many built-in exception types don't include some relevant information in their exceptions' [message] property, so this CL goes back to using [toString] to get string representations of exceptions. The unsightly exception prefixes are now removed via regular expression. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=32045

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+31 lines, -49 lines)
M pkg/barback/lib/src/serialize.dart View 1 chunk +10 lines, -16 lines 0 comments
M pkg/barback/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart View 1 chunk +10 lines, -16 lines 0 comments
M sdk/lib/_internal/pub/lib/src/utils.dart View 1 chunk +10 lines, -16 lines 0 comments

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 11 months ago (2014-01-27 22:48:58 UTC) #1
Bob Nystrom
lgtm
6 years, 11 months ago (2014-01-27 22:59:00 UTC) #2
nweiz
6 years, 11 months ago (2014-01-28 00:14:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r32045 (presubmit successful).

Powered by Google App Engine