Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 14097006: A patch class must be given the same name as the class it is patching, otherwise (Closed)

Created:
7 years, 8 months ago by regis
Modified:
7 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

A patch class must be given the same name as the class it is patching, otherwise the generic signature classes it defines will not match the patched generic signature classes. Therefore, new signature classes will be introduced and the original ones will not get finalized. Committed: https://code.google.com/p/dart/source/detail?r=21235

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M runtime/vm/parser.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
regis
7 years, 8 months ago (2013-04-10 22:06:12 UTC) #1
Ivan Posva
LGTM -ip
7 years, 8 months ago (2013-04-10 22:28:06 UTC) #2
Ivan Posva
On 2013/04/10 22:28:06, Ivan Posva wrote: > LGTM -ip Actually we should also update the ...
7 years, 8 months ago (2013-04-10 22:32:02 UTC) #3
regis
7 years, 8 months ago (2013-04-10 22:34:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r21235 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698