Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Issue 14092006: Move pub's arg parsing to bin/pub.dart. (Closed)

Created:
7 years, 8 months ago by nweiz
Modified:
7 years, 8 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move pub's arg parsing to bin/pub.dart. Committed: https://code.google.com/p/dart/source/detail?r=21991

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -537 lines) Patch
M sdk/lib/_internal/pub/bin/pub.dart View 1 chunk +153 lines, -3 lines 0 comments Download
A + sdk/lib/_internal/pub/lib/src/command.dart View 1 chunk +20 lines, -176 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/command_cache.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/command_help.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/command_install.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command_lish.dart View 2 chunks +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command_update.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command_uploader.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command_version.dart View 2 chunks +5 lines, -2 lines 0 comments Download
D sdk/lib/_internal/pub/lib/src/pub.dart View 1 chunk +0 lines, -348 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years, 8 months ago (2013-04-24 21:39:29 UTC) #1
Bob Nystrom
LGTM.
7 years, 8 months ago (2013-04-24 22:16:24 UTC) #2
nweiz
7 years, 8 months ago (2013-04-24 22:18:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21991 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698