Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 14092004: Chaining of setup/teardown. (Closed)

Created:
7 years, 8 months ago by gram
Modified:
7 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Chaining of setup/teardown. Committed: https://code.google.com/p/dart/source/detail?r=21819

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -75 lines) Patch
M pkg/pkg.status View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/scheduled_test/test/scheduled_test/set_up_test.dart View 1 2 2 chunks +1 line, -41 lines 0 comments Download
M pkg/unittest/lib/src/test_case.dart View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/unittest/lib/unittest.dart View 1 2 6 chunks +64 lines, -30 lines 0 comments Download
M pkg/unittest/test/unittest_test.dart View 1 2 3 chunks +49 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
gram
7 years, 8 months ago (2013-04-19 23:42:59 UTC) #1
Siggi Cherem (dart-lang)
lgtm, with a suggestion... https://codereview.chromium.org/14092004/diff/1/pkg/unittest/lib/unittest.dart File pkg/unittest/lib/unittest.dart (right): https://codereview.chromium.org/14092004/diff/1/pkg/unittest/lib/unittest.dart#newcode636 pkg/unittest/lib/unittest.dart:636: _parentTeardown = _oldParentTeardown; now that ...
7 years, 8 months ago (2013-04-19 23:55:05 UTC) #2
gram
7 years, 8 months ago (2013-04-22 17:11:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r21819 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698