Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 140903003: Making readonly fields on interfaces be readonly (Closed)

Created:
6 years, 11 months ago by blois
Modified:
6 years, 11 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Making readonly fields on interfaces be readonly This will be causing compilation warnings once https://codereview.chromium.org/140803002 is landed. BUG=16105 R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=31892

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -37 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 6 chunks +22 lines, -22 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 5 chunks +12 lines, -12 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
6 years, 11 months ago (2014-01-16 18:08:04 UTC) #1
vsm
lgtm
6 years, 11 months ago (2014-01-16 18:09:31 UTC) #2
blois
6 years, 11 months ago (2014-01-16 18:13:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31892 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698