Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Issue 140853005: update custom elements and shadow dom (Closed)

Created:
6 years, 11 months ago by Jennifer Messerly
Modified:
6 years, 10 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

update custom elements and shadow dom R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=32171

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1392 lines, -1068 lines) Patch
M pkg/custom_element/lib/custom-elements.debug.js View 21 chunks +74 lines, -587 lines 0 comments Download
M pkg/custom_element/lib/custom-elements.min.js View 1 chunk +1 line, -1 line 0 comments Download
M pkg/custom_element/lib/polyfill.dart View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A pkg/shadow_dom/REVISIONS View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/shadow_dom/lib/shadow_dom.debug.js View 1 2 76 chunks +1277 lines, -461 lines 0 comments Download
M pkg/shadow_dom/lib/shadow_dom.min.js View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/shadow_dom/lib/src/platform/patches-shadowdom-polyfill.js View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/shadow_dom/tool/build.sh View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M tests/html/html.status View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tests/html/utils.dart View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M tools/dom/src/dart2js_CustomElementSupport.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Document.darttemplate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Jennifer Messerly
Seems to be working across Dartium/Chrome/FF/Safari. note that some things that used to run under ...
6 years, 11 months ago (2014-01-27 19:44:31 UTC) #1
blois
lgtm (though take a look at IE) FYI- for tracking the github rev in third_party/pkg, ...
6 years, 11 months ago (2014-01-27 20:20:25 UTC) #2
blois
https://codereview.chromium.org/140853005/diff/1/tools/dom/src/dart2js_CustomElementSupport.dart File tools/dom/src/dart2js_CustomElementSupport.dart (right): https://codereview.chromium.org/140853005/diff/1/tools/dom/src/dart2js_CustomElementSupport.dart#newcode102 tools/dom/src/dart2js_CustomElementSupport.dart:102: JS('void', '#.attachedCallback = #', properties, Can keep both enteredView ...
6 years, 11 months ago (2014-01-28 00:15:26 UTC) #3
Jennifer Messerly
Good idea about the REVISION file, will switch to that. https://codereview.chromium.org/140853005/diff/1/pkg/custom_element/lib/custom-elements.debug.js File pkg/custom_element/lib/custom-elements.debug.js (left): https://codereview.chromium.org/140853005/diff/1/pkg/custom_element/lib/custom-elements.debug.js#oldcode59 ...
6 years, 10 months ago (2014-01-29 20:52:36 UTC) #4
Jennifer Messerly
PTAL. now has revisions file & mutation observers fallback
6 years, 10 months ago (2014-01-29 23:47:21 UTC) #5
blois
lgtm
6 years, 10 months ago (2014-01-29 23:52:59 UTC) #6
Jennifer Messerly
6 years, 10 months ago (2014-01-30 20:56:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r32171 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698