Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1408423006: Fix the tests. (Closed)

Created:
5 years, 2 months ago by nweiz
Modified:
5 years, 2 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix the tests. This includes several fixes: * It upgrades to the latest compiler_unsupported which uses dart:developer rather than dart:profiler, * It fixes the test runner detection to match the new spawning mechanism. * It works around dart-lang/sdk#24653 in a dart2js test. * It upgrades an invocation of `new oauth2.Credentials()` to match the new oauth2 API. Closes #1346 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/e803009df846be1a15b56c8e1bc913abff1cd281

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M lib/src/io.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 2 comments Download
M test/dart2js/supports_valid_options_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M test/descriptor.dart View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
5 years, 2 months ago (2015-10-20 20:58:20 UTC) #1
Bob Nystrom
https://codereview.chromium.org/1408423006/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1408423006/diff/1/pubspec.yaml#newcode12 pubspec.yaml:12: compiler_unsupported: "^1.13.0-dev" I thought we, as a rule, didn't ...
5 years, 2 months ago (2015-10-20 21:01:20 UTC) #2
nweiz
https://codereview.chromium.org/1408423006/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1408423006/diff/1/pubspec.yaml#newcode12 pubspec.yaml:12: compiler_unsupported: "^1.13.0-dev" On 2015/10/20 21:01:20, Bob Nystrom wrote: > ...
5 years, 2 months ago (2015-10-20 21:10:46 UTC) #3
Bob Nystrom
SGTM. LGTM!
5 years, 2 months ago (2015-10-20 21:21:51 UTC) #4
nweiz
5 years, 2 months ago (2015-10-20 21:26:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e803009df846be1a15b56c8e1bc913abff1cd281 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698