Issue 14084006: - Reduce warnings about project settings in Xcode 4.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14084006: - Reduce warnings about project settings in Xcode 4. (Closed)

Created:
7 years, 8 months ago by Ivan Posva

Modified:
7 years, 8 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, tfarina

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Reduce warnings about project settings in Xcode 4. - Address compilation warnings found by clang. Committed: https://code.google.com/p/dart/source/detail?r=21786

Patch Set 1 #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -8 lines)			Patch
M	runtime/bin/dbg_message.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/socket_macos.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/simulator_arm.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/simulator_mips.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/gyp/configurations_xcode.gypi	View	1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

Committed patchset #1 manually as r21786 (presubmit successful).

7 years, 8 months ago (2013-04-22 05:31:17 UTC) #2

siva

lgtm https://codereview.chromium.org/14084006/diff/1/tools/gyp/configurations_xcode.gypi File tools/gyp/configurations_xcode.gypi (right): https://codereview.chromium.org/14084006/diff/1/tools/gyp/configurations_xcode.gypi#newcode54 tools/gyp/configurations_xcode.gypi:54: 'COMBINE_HIDPI_IMAGES': 'YES', Just curious, why do we need ...

7 years, 8 months ago (2013-04-22 17:17:27 UTC) #3

Ivan Posva

7 years, 8 months ago (2013-04-22 23:04:45 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/14084006/diff/1/tools/gyp/configurations_xcod...
File tools/gyp/configurations_xcode.gypi (right):

https://codereview.chromium.org/14084006/diff/1/tools/gyp/configurations_xcod...
tools/gyp/configurations_xcode.gypi:54: 'COMBINE_HIDPI_IMAGES': 'YES',
On 2013/04/22 17:17:27, siva wrote:
> Just curious, why do we need this option. Do we have any image files which are
> part of the build?

If you do not set this, then Xcode complains about the setting missing even if
you have no images in the target. Brilliant!

Expand Messages | Collapse Messages