Issue 140783013: use proper notation for true, false, and null in doc comments

Issue 140783013: use proper notation for true, false, and null in doc comments (Closed)

Created:
6 years, 11 months ago by kevmoo

Modified:
6 years, 11 months ago

Reviewers:
Kathy Walrath, Lasse Reichstein Nielsen, Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

use proper notation for true, false, and null in doc comments BUG= https://code.google.com/p/dart/issues/detail?id=16193 R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=31947

Patch Set 3 : long line #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -48 lines)			Patch
M	pkg/csslib/lib/parser.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/csslib/lib/src/analyzer.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/csslib/lib/src/tokenkind.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/csslib/pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/fixnum/lib/src/int32.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/fixnum/lib/src/int64.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/fixnum/pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/unittest/lib/src/configuration.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/unittest/lib/src/test_case.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/unittest/pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dump_info.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/namer.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/tree/prettyprint.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/lib/isolate_helper.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/collection/splay_tree.dart	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/core/expando.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/io/data_transformer.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/io/http.dart	View	1 2	8 chunks	+14 lines, -14 lines	0 comments	Download
M	sdk/lib/io/socket.dart	View		5 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

lgtm https://codereview.chromium.org/140783013/diff/30001/sdk/lib/io/http.dart File sdk/lib/io/http.dart (right): https://codereview.chromium.org/140783013/diff/30001/sdk/lib/io/http.dart#newcode973 sdk/lib/io/http.dart:973: * Gets information about the client connection. Returns ...

6 years, 11 months ago (2014-01-19 12:40:29 UTC) #2

kevmoo

https://codereview.chromium.org/140783013/diff/30001/sdk/lib/io/http.dart File sdk/lib/io/http.dart (right): https://codereview.chromium.org/140783013/diff/30001/sdk/lib/io/http.dart#newcode973 sdk/lib/io/http.dart:973: * Gets information about the client connection. Returns [:null:] ...

6 years, 11 months ago (2014-01-19 19:22:54 UTC) #3

kevmoo

6 years, 11 months ago (2014-01-19 19:24:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r31947 (presubmit successful).

Expand Messages | Collapse Messages