Issue 1407593002: Properly close `setUpAll` and `tearDownAll` tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1407593002: Properly close `setUpAll` and `tearDownAll` tests. (Closed)

Created:
5 years, 2 months ago by nweiz

Modified:
5 years, 2 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -5 lines)			Patch
	M	lib/src/runner/engine.dart	View		4 chunks	+16 lines, -4 lines	0 comments	Download
	M	pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

nweiz

On 2015/10/13 20:16:17, kevmoo wrote: > LGTM – but no tests? The existing tests *should* cover ...

5 years, 2 months ago (2015-10-13 20:17:14 UTC) #3

nweiz

5 years, 2 months ago (2015-10-13 20:17:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9b7eb6b229499cc0ddbca69eeba1795ebb7f26d6 (presubmit successful).