Added beginning support for calc however, the expression is not fully parsed into the AST.

Add partial support for calc

The expression is not fully parsed into the AST.

closes https://github.com/dart-lang/csslib/issues/17

R=kevmoo@google.com, yjbanov@google.com, kevinmoo@google.com

Committed: https://github.com/dart-lang/csslib/commit/3cc40426ce22572c43b5d45906279aede6309747

[terry, 2015-10-16 17:11:05]

PTAL Kevin what pubspec version should I use currently it's

version: 0.12.2-dev

should it become 0.13.0-dev ?

[kevmoo, 2015-10-16 17:39:12]

kevmoo@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2015-10-16 17:39:12]

Update the pubspec to 0.12.2

Add a corresponding entry to the CHANGELOG – about (partial?) support for calc

Then we can publish!

https://codereview.chromium.org/1407333002/diff/1/test/declaration_test.dart
File test/declaration_test.dart (right):

https://codereview.chromium.org/1407333002/diff/1/test/declaration_test.dart#...
test/declaration_test.dart:1077: test('Declaration span containing calc()',
testDeclarationSpanWithCalc);
make this a group and break the 'testDeclarationSpanWithCalc method into three
nested tests – just put the content here, me thinks

[yjbanov, 2015-10-16 17:39:22]

On 2015/10/16 17:11:05, terry wrote:
> PTAL Kevin what pubspec version should I use currently it's
> 
> version: 0.12.2-dev
> 
> should it become 0.13.0-dev ?

LGTM

[yjbanov, 2015-10-16 17:39:55]

LGTM

https://codereview.chromium.org/1407333002/diff/1/lib/parser.dart
File lib/parser.dart (right):

https://codereview.chromium.org/1407333002/diff/1/lib/parser.dart#newcode2488
lib/parser.dart:2488: processCalc(Identifier func) {
missing return type

[kevmoo, 2015-10-16 17:56:39]

https://codereview.chromium.org/1407333002/diff/1/lib/parser.dart
File lib/parser.dart (right):

https://codereview.chromium.org/1407333002/diff/1/lib/parser.dart#newcode2459
lib/parser.dart:2459: var start = _peekToken.span;
start seems to not be used

https://codereview.chromium.org/1407333002/diff/1/lib/src/tree.dart
File lib/src/tree.dart (right):

https://codereview.chromium.org/1407333002/diff/1/lib/src/tree.dart#newcode59
lib/src/tree.dart:59: String toString() => "$t($expr)";
Where is `t` coming from? you mean `$text`?

[terry, 2015-10-16 18:28:47]

PTAL

https://codereview.chromium.org/1407333002/diff/1/lib/parser.dart
File lib/parser.dart (right):

https://codereview.chromium.org/1407333002/diff/1/lib/parser.dart#newcode2459
lib/parser.dart:2459: var start = _peekToken.span;
On 2015/10/16 17:56:39, kevmoo wrote:
> start seems to not be used

Right, not used now but will be when fully parsed.  I'll remove.

https://codereview.chromium.org/1407333002/diff/1/lib/parser.dart#newcode2488
lib/parser.dart:2488: processCalc(Identifier func) {
On 2015/10/16 17:39:55, yjbanov wrote:
> missing return type

Done.

https://codereview.chromium.org/1407333002/diff/1/lib/src/tree.dart
File lib/src/tree.dart (right):

https://codereview.chromium.org/1407333002/diff/1/lib/src/tree.dart#newcode59
lib/src/tree.dart:59: String toString() => "$t($expr)";
On 2015/10/16 17:56:39, kevmoo wrote:
> Where is `t` coming from? you mean `$text`?

Done.

https://codereview.chromium.org/1407333002/diff/1/test/declaration_test.dart
File test/declaration_test.dart (right):

https://codereview.chromium.org/1407333002/diff/1/test/declaration_test.dart#...
test/declaration_test.dart:1077: test('Declaration span containing calc()',
testDeclarationSpanWithCalc);
On 2015/10/16 17:39:12, kevmoo wrote:
> make this a group and break the 'testDeclarationSpanWithCalc method into three
> nested tests – just put the content here, me thinks

Done.

[kevmoo, 2015-10-16 18:34:05]

LGTM

don't forget to add a line to the CHANGELOG, too

https://codereview.chromium.org/1407333002/diff/40001/test/declaration_test.dart
File test/declaration_test.dart (right):

https://codereview.chromium.org/1407333002/diff/40001/test/declaration_test.d...
test/declaration_test.dart:1084: test('simple calc', simpleCalc);
you can just put the anonymous methods here – a bit easier to read

not a big deal, though

[terry, 2015-10-16 18:40:32]

On 2015/10/16 18:34:05, kevmoo wrote:
> LGTM
> 
> don't forget to add a line to the CHANGELOG, too
> 
>
https://codereview.chromium.org/1407333002/diff/40001/test/declaration_test.dart
> File test/declaration_test.dart (right):
> 
>
https://codereview.chromium.org/1407333002/diff/40001/test/declaration_test.d...
> test/declaration_test.dart:1084: test('simple calc', simpleCalc);
> you can just put the anonymous methods here – a bit easier to read
> 
> not a big deal, though

Done. Thanks for reminding me.

[terry, 2015-10-16 18:44:36]

Committed patchset #4 (id:60001) manually as
3cc40426ce22572c43b5d45906279aede6309747 (presubmit successful).