Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1407283008: Verify type annotations on public APIs (#24). (Closed)

Created:
5 years, 1 month ago by pquitslund
Modified:
5 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/linter.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Verify type annotaions on public APIs (#24). * Implements #24. * Tweaks the rule boilerplate generator. BUG= R=scheglov@google.com Committed: https://github.com/dart-lang/linter/commit/4b2af08156718e849c4722f42d765ea75246a814

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -9 lines) Patch
M lib/src/ast.dart View 2 chunks +5 lines, -0 lines 0 comments Download
M lib/src/rules.dart View 3 chunks +3 lines, -1 line 0 comments Download
A lib/src/rules/type_annotate_public_apis.dart View 1 chunk +133 lines, -0 lines 0 comments Download
A test/rules/type_annotate_public_apis.dart View 1 chunk +46 lines, -0 lines 0 comments Download
M tool/rule.dart View 2 chunks +21 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
pquitslund
5 years, 1 month ago (2015-11-05 19:05:36 UTC) #2
scheglov
LGTM
5 years, 1 month ago (2015-11-05 19:15:01 UTC) #3
pquitslund
5 years, 1 month ago (2015-11-05 19:26:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4b2af08156718e849c4722f42d765ea75246a814 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698