Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 14070006: Dartdoc: Fix missing space after 'dynamic' in member declarations in generated docs. (Closed)

Created:
7 years, 8 months ago by Bill Hesse
Modified:
7 years, 8 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, Johnni Winther
Visibility:
Public.

Description

Dartdoc: Fix missing space after 'dynamic' in member declarations in generated docs. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21210

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sdk/lib/_internal/dartdoc/lib/dartdoc.dart View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 4 (0 generated)
Bill Hesse
7 years, 8 months ago (2013-04-10 15:36:47 UTC) #1
kustermann
lgtm
7 years, 8 months ago (2013-04-10 15:39:48 UTC) #2
Bill Hesse
https://codereview.chromium.org/14070006/diff/1/sdk/lib/_internal/dartdoc/lib/dartdoc.dart File sdk/lib/_internal/dartdoc/lib/dartdoc.dart (right): https://codereview.chromium.org/14070006/diff/1/sdk/lib/_internal/dartdoc/lib/dartdoc.dart#newcode1709 sdk/lib/_internal/dartdoc/lib/dartdoc.dart:1709: } annotateDynamicType is only used in one place, to ...
7 years, 8 months ago (2013-04-10 15:40:42 UTC) #3
Bill Hesse
7 years, 8 months ago (2013-04-10 15:40:43 UTC) #4
Committed patchset #1 manually as r21210 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698