Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 14069019: Implements context allocation stub for MIPS. (Closed)

Created:
7 years, 8 months ago by zra
Modified:
7 years, 8 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implements context allocation stub for MIPS. Also removes uses of Push and Pop macros. Committed: https://code.google.com/p/dart/source/detail?r=21824

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -78 lines) Patch
M runtime/vm/custom_isolate_test.cc View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 2 3 chunks +32 lines, -20 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 2 4 chunks +37 lines, -12 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 2 9 chunks +171 lines, -39 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zra
7 years, 8 months ago (2013-04-20 00:19:11 UTC) #1
regis
LGTM https://codereview.chromium.org/14069019/diff/6001/runtime/vm/stub_code_mips.cc File runtime/vm/stub_code_mips.cc (right): https://codereview.chromium.org/14069019/diff/6001/runtime/vm/stub_code_mips.cc#newcode701 runtime/vm/stub_code_mips.cc:701: __ BranchGreaterEqual(T3, TMP1, &slow_case); The use_slow_path flag is ...
7 years, 8 months ago (2013-04-22 16:03:38 UTC) #2
zra
Thanks! https://codereview.chromium.org/14069019/diff/6001/runtime/vm/stub_code_mips.cc File runtime/vm/stub_code_mips.cc (right): https://codereview.chromium.org/14069019/diff/6001/runtime/vm/stub_code_mips.cc#newcode701 runtime/vm/stub_code_mips.cc:701: __ BranchGreaterEqual(T3, TMP1, &slow_case); On 2013/04/22 16:03:38, regis ...
7 years, 8 months ago (2013-04-22 17:38:24 UTC) #3
zra
7 years, 8 months ago (2013-04-22 17:39:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r21824 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698