Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1406803003: add tool to verify dependency information (Closed)

Created:
5 years, 2 months ago by Harry Terkelsen
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:hterkelsen/dart2js_info.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

add tool to verify dependency information the tools verifies that all elements are reachable from main BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/dart2js_info/commit/11c920c72606869c528f27e7eb05fb7911dc724c

Patch Set 1 #

Patch Set 2 : changelog #

Total comments: 8

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -17 lines) Patch
M CHANGELOG.md View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M README.md View 1 2 8 chunks +30 lines, -7 lines 0 comments Download
M bin/code_deps.dart View 1 chunk +1 line, -1 line 0 comments Download
M bin/debug_info.dart View 1 chunk +1 line, -1 line 0 comments Download
M bin/function_size_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M bin/inference/client.dart View 1 chunk +1 line, -1 line 0 comments Download
M bin/inference/print_summary.dart View 1 chunk +1 line, -1 line 0 comments Download
M bin/library_size_split.dart View 1 chunk +1 line, -1 line 0 comments Download
M bin/live_code_size_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
A bin/verify_deps.dart View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
M lib/info.dart View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M pubspec.yaml View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M test/all_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Harry Terkelsen
5 years, 2 months ago (2015-10-14 23:14:38 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1406803003/diff/20001/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1406803003/diff/20001/CHANGELOG.md#newcode3 CHANGELOG.md:3: ## 0.1.1 FYI up to you if you ...
5 years, 2 months ago (2015-10-14 23:37:02 UTC) #3
Harry Terkelsen
https://codereview.chromium.org/1406803003/diff/20001/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1406803003/diff/20001/CHANGELOG.md#newcode3 CHANGELOG.md:3: ## 0.1.1 On 2015/10/14 23:37:02, Siggi Cherem (dart-lang) wrote: ...
5 years, 2 months ago (2015-10-15 00:13:55 UTC) #4
Harry Terkelsen
5 years, 2 months ago (2015-10-15 00:15:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
11c920c72606869c528f27e7eb05fb7911dc724c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698