Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 14067002: Incrementally recompute dominators when inlining. (Closed)

Created:
7 years, 8 months ago by Kevin Millikin (Google)
Modified:
7 years, 8 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Incrementally recompute dominators when inlining. Before: we marked the entire graph's dominator tree invalid in case there were multiple exits from an inlined function and recomputed dominators after inlining. Now: in case there are multiple exits we collect them in a fresh join block and compute its immediate dominator as the nearest common ancestor in the dominator tree over all predecessors. Committed: https://code.google.com/p/dart/source/detail?r=21268

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -118 lines) Patch
M runtime/vm/flow_graph.h View 2 chunks +2 lines, -7 lines 0 comments Download
M runtime/vm/flow_graph.cc View 3 chunks +1 line, -12 lines 0 comments Download
M runtime/vm/flow_graph_builder.h View 4 chunks +13 lines, -9 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 3 chunks +146 lines, -87 lines 1 comment Download
M runtime/vm/flow_graph_inliner.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Google)
7 years, 8 months ago (2013-04-10 14:03:21 UTC) #1
Florian Schneider
LGTM. https://codereview.chromium.org/14067002/diff/1/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://codereview.chromium.org/14067002/diff/1/runtime/vm/flow_graph_builder.cc#newcode179 runtime/vm/flow_graph_builder.cc:179: ASSERT(j >= 1); I think you can even ...
7 years, 8 months ago (2013-04-11 11:30:18 UTC) #2
Kevin Millikin (Google)
7 years, 8 months ago (2013-04-11 11:44:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21268 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698