Issue 14066019: Change memberName and namedArguments in Invocation to use Symbol.

Issue 14066019: Change memberName and namedArguments in Invocation to use Symbol. (Closed)

Created:
7 years, 8 months ago by ahe

Modified:
7 years, 8 months ago

Reviewers:
Johnni Winther, regis, Ivan Posva

CC:
reviews_dartlang.org, gbracha, erikcorry

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Change memberName and namedArguments in Invocation to use Symbol. Committed: https://code.google.com/p/dart/source/detail?r=21602

Patch Set 1 : #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+227 lines, -119 lines)			Patch
M	dart/pkg/pkg.status	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	dart/pkg/unittest/lib/mock.dart	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	dart/runtime/lib/invocation_mirror_patch.dart	View	2 chunks	+13 lines, -9 lines	0 comments	Download
M	dart/runtime/lib/object_patch.dart	View	2 chunks	+10 lines, -2 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/lib/core_patch.dart	View	3 chunks	+16 lines, -5 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart	View	2 chunks	+12 lines, -6 lines	0 comments	Download
M	dart/sdk/lib/core/invocation.dart	View	1 chunk	+2 lines, -2 lines	2 comments	Download
M	dart/tests/co19/co19-dart2js.status	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	dart/tests/co19/co19-runtime.status	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	dart/tests/language/invocation_mirror_test.dart	View	8 chunks	+133 lines, -81 lines	0 comments	Download
M	dart/tests/language/language_dart2js.status	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	dart/tests/language/no_such_method_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/language/super_call4_test.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	dart/tests/language/super_getter_setter_test.dart	View	2 chunks	+7 lines, -4 lines	0 comments	Download
M	dart/tests/language/super_operator_index5_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/language/super_operator_index6_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/language/super_operator_index7_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

+regis LGTM. Just making sure that Regis knows about these changes. -Ivan https://codereview.chromium.org/14066019/diff/7001/dart/sdk/lib/core/invocation.dart File dart/sdk/lib/core/invocation.dart ...

7 years, 8 months ago (2013-04-16 18:19:49 UTC) #2

ahe

Hi Ivan, Thank you for taking a look. Cheers, Peter https://codereview.chromium.org/14066019/diff/7001/dart/sdk/lib/core/invocation.dart File dart/sdk/lib/core/invocation.dart (right): https://codereview.chromium.org/14066019/diff/7001/dart/sdk/lib/core/invocation.dart#newcode15 ...

7 years, 8 months ago (2013-04-16 18:32:00 UTC) #3

ahe

7 years, 8 months ago (2013-04-17 07:55:06 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 manually as r21602 (presubmit successful).

Expand Messages | Collapse Messages